search

commercetools / commercetools-sunrise-theme

Sunrise Theme from commercetools
http://commercetools.github.io/commercetools-sunrise-theme/site/en/home.html
13 stars 16 forks source link

Home: a lot of spacing #365

Closed adnasa closed 8 years ago

adnasa commented 8 years ago

Is this meant to be?

img

lauraluiz commented 8 years ago

@andalusi I reverted your fix (https://github.com/sphereio/commercetools-sunrise-design/commit/249a59f24852f4e2adea29a2db96de0851a39cff) because it caused this. Any idea how to solve it?

andalusi commented 8 years ago

@lauraluiz Unfortunately, it won't fix the issue when change the height value from auto to 100% because small images will stretch. I would temporary recommend to hide the loading animation and only use images with the correct aspect ratio.

lauraluiz commented 8 years ago

@andalusi okay for the temporary solution, but what would be the long-term solution that you suggest?

andalusi commented 8 years ago

@lauraluiz Using the right aspect ratio

lauraluiz commented 8 years ago

@andalusi do you mean for the product thumbnails or for the home page banners?

andalusi commented 8 years ago

@lauraluiz For both! But I know its not always possible. So we can use two different mixins, one for home banners (height: auto) and one for product thumbnails (height: 100%) Not sure if this is a kind of a hack ... ;)

lauraluiz commented 8 years ago

@andalusi as long as it works, it is okay :) We definitely cannot guarantee what kind of images people will provide with their products, that must be completely flexible. But we can be a bit more strict with the home banners, if needed.

andalusi commented 8 years ago

Fixed: Product thumbnails with landscape pictures #358

lauraluiz commented 8 years ago

Solved :+1: