search

commercetools / merchant-center-application-kit

Tools and components for developing Merchant Center Customizations 🛠
https://docs.commercetools.com/merchant-center-customizations
MIT License
67 stars 27 forks source link

Reverting `header-polyfill` dependency resolution (fix starter templates tests) #3505

Closed CarlosCortizasCT closed 5 months ago

CarlosCortizasCT commented 5 months ago

Summary

Reverting header-polyfill dependency resolution (fix starter templates tests)

closes #3498

Description

We have the starter templates tests failing again.

The original problem was a dependency update which was incompatible with our version of msw as we explained and fixed in this PR.

We have the issue again because we unintentionally updated the dependency resolution we had set (in this PR). That dependency resolution can't be updated until we move to msw version 2, which requires some effort.

changeset-bot[bot] commented 5 months ago

⚠️ No Changeset found

Latest commit: 0434006ee98250942090cf7666530ee5aca68d0b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 5 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
merchant-center-application-kit-components-playground ✅ Ready (Inspect) Visit Preview May 2, 2024 7:57pm
emmenko commented 5 months ago

Needs a changeset also

Not strictly needed for the templates