Open antoniolodias opened 5 months ago
Hi 👋, Thank you for reporting this issue. To clarify, our notification system offers three types of notifications: global, page, and side notifications.
According to our documentation:
Notifications are grouped by so-called
domains
. A domain specifies where the notification should be displayed on the page (for instancepage
andside
).
Therefore, this choice of positioning of the side-domain notifications container in the page (instead of fixed positioning against the viewport) appears to be intentional.
Please mind about the bits:
Be mindful of your users when dispatching notifications. Excessive and confusing notifications can lead to a poor user experience. Generally,
error
notifications should be displayed in the page domain rather than the side domain.
I’m tagging @FilPob to see if we need to revisit any aspects of this.
Hi there @kark 👋 Thanks for looking into this!
The Global
type might work, thank you for pointing that out, but at the same time I don't understand why would we want to trigger a side toast notification that is not visible.
Hey @antoniolodias 👋,
I don't understand why would we want to trigger a side toast notification that is not visible
Thanks for pointing that out, that's a fair point. We definitely don't want that to happen. But we need to look into the tradeoffs of orienting side and page notifications against the viewport. For instance, users with smaller viewports won't be able to see bottom notifications because they wouldn't have the option to scroll, unlike they are able to do now.
We'll investigate this further.
Thanks for bringing it up!
Thank you @kark
I thought the solution could be setting the notifications' container with position fixed instead of relative and allow scroll if needed. But I can be over simplifying it... The UIUX team might have some guidance as well. Thank you again for looking into this!!
Describe the issue
Toast notification seems to be attached to page top instead of screen top, so if you scroll down and click something that gives some kind of notification, this won't be seen
To Reproduce
1. If you look before PR merge: https://mc-16889.mc-preview.europe-west1.gcp.escemo.com/blt-nail/orders/new/order-details otherwise: https://mc.europe-west1.gcp.escemo.com/blt-nail/orders/new/order-details
Expected behaviour
Toast notification should be always visible regardless of your scroll position
recording
https://github.com/commercetools/merchant-center-application-kit/assets/37903776/38711ab3-09f8-4be7-b5a2-fd8e2152f24a