commercetools / merchant-center-application-kit

Tools and components for developing Merchant Center Customizations 🛠
https://docs.commercetools.com/merchant-center-customizations
MIT License
66 stars 27 forks source link

refactor: change http-adapter to eager mode #3548

Closed tdeekens closed 1 month ago

tdeekens commented 1 month ago

Summary

We've been to lazy and should be more eager.

Description

After a lot of communication and alignment we realized that being eager on the http-adapter helps drive user expectations.

The background is that we toggle functionality through the http-adapter which is generally available to users. Having a "delayed" appearing through a reload for these functionalities is not ideal. It's acceptable for anything which sits behind LaunchDarkly and there has also the benefit to avoid the flicker.

Followings

  1. @CarlosCortizasCT will evaluate the delay waiting for flags would actually cost and if we can globally wait
  2. @tdeekens will investigate if we can integrate our http-adapter query into a more global GraphQL query and hydrate the memory-adapter with it to avoid flash flickering

The general storyline is also to get flopflip ready for React Suspense finally when time permits.

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mc-app-kit-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 7, 2024 2:22pm
merchant-center-application-kit-components-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 7, 2024 2:22pm
changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: ed7f8c3a9014174a1c97d513dd35907f33f83203

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages | Name | Type | | ----------------------------------------------------------------------------------- | ----- | | @commercetools-frontend/application-shell | Patch | | @commercetools-frontend/cypress | Patch | | @commercetools-applications/merchant-center-template-starter-typescript | Patch | | @commercetools-applications/merchant-center-template-starter | Patch | | @commercetools-applications/merchant-center-custom-view-template-starter-typescript | Patch | | @commercetools-applications/merchant-center-custom-view-template-starter | Patch | | @commercetools-local/playground | Patch | | @commercetools-local/visual-testing-app | Patch | | @commercetools-backend/eslint-config-node | Patch | | @commercetools-backend/express | Patch | | @commercetools-backend/loggers | Patch | | @commercetools-frontend/actions-global | Patch | | @commercetools-frontend/application-components | Patch | | @commercetools-frontend/application-config | Patch | | @commercetools-frontend/application-shell-connectors | Patch | | @commercetools-frontend/assets | Patch | | @commercetools-frontend/babel-preset-mc-app | Patch | | @commercetools-frontend/browser-history | Patch | | @commercetools-frontend/codemod | Patch | | @commercetools-frontend/constants | Patch | | @commercetools-frontend/create-mc-app | Patch | | @commercetools-frontend/eslint-config-mc-app | Patch | | @commercetools-frontend/i18n | Patch | | @commercetools-frontend/jest-preset-mc-app | Patch | | @commercetools-frontend/jest-stylelint-runner | Patch | | @commercetools-frontend/l10n | Patch | | @commercetools-frontend/mc-dev-authentication | Patch | | @commercetools-frontend/mc-html-template | Patch | | @commercetools-frontend/mc-scripts | Patch | | @commercetools-frontend/notifications | Patch | | @commercetools-frontend/permissions | Patch | | @commercetools-frontend/react-notifications | Patch | | @commercetools-frontend/sdk | Patch | | @commercetools-frontend/sentry | Patch | | @commercetools-frontend/url-utils | Patch | | @commercetools-website/components-playground | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

gitstream-cm[bot] commented 1 month ago

This PR is missing a Jira ticket reference in the title or description. Please add a Jira ticket reference to the title or description of this PR.

gitstream-cm[bot] commented 1 month ago

🥷 Code experts: emmenko

tdeekens, emmenko have most 👩‍💻 activity in the files. tdeekens, emmenko have most 🧠 knowledge in the files.

See details `packages/application-shell/src/components/setup-flop-flip-provider/setup-flop-flip-provider.tsx` Activity based on git-commit: | | tdeekens | emmenko| | --- | --- | --- | | JUN | | | MAY | |12 additions & 2 deletions | | APR | 5 additions & 2 deletions | | MAR | 3 additions & 0 deletions |1 additions & 1 deletions | | FEB | | | JAN | | Knowledge based on git-blame: tdeekens: 48% emmenko: 27%

To learn more about /:\ gitStream - Visit our Docs