commercetools / merchant-center-application-kit

Tools and components for developing Merchant Center Customizations 🛠
https://docs.commercetools.com/merchant-center-customizations
MIT License
67 stars 27 forks source link

fix(customizations templates): include babel-preset package as a dependency #3551

Closed kark closed 3 months ago

kark commented 3 months ago

Summary

Creating and starting a new customization using yarn v3 is currently failing:

Error: Your application tried to access @commercetools-frontend/babel-preset-mc-app, but it isn't declared in your dependencies; this makes the require call ambiguous and unsound.

Make sure that all the Babel plugins and presets you are using
are defined as dependencies or devDependencies in your package.json
file. It's possible that the missing plugin is loaded by a preset
you are using that forgot to add the plugin to its dependencies: you
can workaround this problem by explicitly adding the missing package
to your top-level package.json.

Adding the babel preset dependency appears to solve the issue.

The alternative would be to only allow yarn classic.

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mc-app-kit-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 19, 2024 11:07am
merchant-center-application-kit-components-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 19, 2024 11:07am
changeset-bot[bot] commented 3 months ago

🦋 Changeset detected

Latest commit: 1fee454eb839819dbc6a4811de8e4482e5b45291

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages | Name | Type | | ----------------------------------------------------------------------------------- | ----- | | @commercetools-applications/merchant-center-custom-view-template-starter-typescript | Patch | | @commercetools-applications/merchant-center-template-starter-typescript | Patch | | @commercetools-applications/merchant-center-custom-view-template-starter | Patch | | @commercetools-applications/merchant-center-template-starter | Patch | | @commercetools-backend/eslint-config-node | Patch | | @commercetools-backend/express | Patch | | @commercetools-backend/loggers | Patch | | @commercetools-frontend/actions-global | Patch | | @commercetools-frontend/application-components | Patch | | @commercetools-frontend/application-config | Patch | | @commercetools-frontend/application-shell-connectors | Patch | | @commercetools-frontend/application-shell | Patch | | @commercetools-frontend/assets | Patch | | @commercetools-frontend/babel-preset-mc-app | Patch | | @commercetools-frontend/browser-history | Patch | | @commercetools-frontend/codemod | Patch | | @commercetools-frontend/constants | Patch | | @commercetools-frontend/create-mc-app | Patch | | @commercetools-frontend/cypress | Patch | | @commercetools-frontend/eslint-config-mc-app | Patch | | @commercetools-frontend/i18n | Patch | | @commercetools-frontend/jest-preset-mc-app | Patch | | @commercetools-frontend/jest-stylelint-runner | Patch | | @commercetools-frontend/l10n | Patch | | @commercetools-frontend/mc-dev-authentication | Patch | | @commercetools-frontend/mc-html-template | Patch | | @commercetools-frontend/mc-scripts | Patch | | @commercetools-frontend/notifications | Patch | | @commercetools-frontend/permissions | Patch | | @commercetools-frontend/react-notifications | Patch | | @commercetools-frontend/sdk | Patch | | @commercetools-frontend/sentry | Patch | | @commercetools-frontend/url-utils | Patch | | @commercetools-local/playground | Patch | | @commercetools-local/visual-testing-app | Patch | | @commercetools-website/components-playground | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

gitstream-cm[bot] commented 3 months ago

This PR is missing a Jira ticket reference in the title or description. Please add a Jira ticket reference to the title or description of this PR.

gitstream-cm[bot] commented 3 months ago

🥷 Code experts: emmenko

emmenko has most 🧠 knowledge in the files.

See details `application-templates/starter-typescript/package.json` Knowledge based on git-blame: emmenko: 29% `application-templates/starter/package.json` Knowledge based on git-blame: emmenko: 48% `custom-views-templates/starter-typescript/package.json` Knowledge based on git-blame: emmenko: 8% `custom-views-templates/starter/package.json` Knowledge based on git-blame: emmenko: 1% `pnpm-lock.yaml` Knowledge based on git-blame: emmenko: 55%

To learn more about /:\ gitStream - Visit our Docs