commercetools / merchant-center-application-kit

Tools and components for developing Merchant Center Customizations 🛠
https://docs.commercetools.com/merchant-center-customizations
MIT License
67 stars 27 forks source link

chore(message-loader): convert to opt-out with fallback strategy #3556

Closed dogayuksel closed 3 months ago

dogayuksel commented 3 months ago

Summary

Sets message compilation as opt-out.

If for some reason compilation fails:


When the message file compilation throws an error it looks something like this (webpack):

Screenshot 2024-06-24 at 14 11 26

Notice @formatjs/cli warning printed to stdout. This does not get propagated through webpack stats, should not cause CI build to fail.

As a sanity check, I have introduced i18n syntax errors on commit: https://github.com/commercetools/merchant-center-application-kit/pull/3556/commits/cbbf361be2cb46ba20fa6bd1ff702852aef4f83c and ran the pipeline: https://github.com/commercetools/merchant-center-application-kit/actions/runs/9645464336

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mc-app-kit-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 26, 2024 7:57am
merchant-center-application-kit-components-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 26, 2024 7:57am
changeset-bot[bot] commented 3 months ago

🦋 Changeset detected

Latest commit: c73cf3aa3b67053d30938d3f487101a7fd64ebba

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages | Name | Type | | ----------------------------------------------------------------------------------- | ----- | | @commercetools-frontend/mc-scripts | Minor | | @commercetools-applications/merchant-center-template-starter-typescript | Minor | | @commercetools-applications/merchant-center-template-starter | Minor | | @commercetools-applications/merchant-center-custom-view-template-starter-typescript | Minor | | @commercetools-applications/merchant-center-custom-view-template-starter | Minor | | @commercetools-local/playground | Minor | | @commercetools-backend/eslint-config-node | Minor | | @commercetools-backend/express | Minor | | @commercetools-backend/loggers | Minor | | @commercetools-frontend/actions-global | Minor | | @commercetools-frontend/application-components | Minor | | @commercetools-frontend/application-config | Minor | | @commercetools-frontend/application-shell-connectors | Minor | | @commercetools-frontend/application-shell | Minor | | @commercetools-frontend/assets | Minor | | @commercetools-frontend/babel-preset-mc-app | Minor | | @commercetools-frontend/browser-history | Minor | | @commercetools-frontend/codemod | Minor | | @commercetools-frontend/constants | Minor | | @commercetools-frontend/create-mc-app | Minor | | @commercetools-frontend/cypress | Minor | | @commercetools-frontend/eslint-config-mc-app | Minor | | @commercetools-frontend/i18n | Minor | | @commercetools-frontend/jest-preset-mc-app | Minor | | @commercetools-frontend/jest-stylelint-runner | Minor | | @commercetools-frontend/l10n | Minor | | @commercetools-frontend/mc-dev-authentication | Minor | | @commercetools-frontend/mc-html-template | Minor | | @commercetools-frontend/notifications | Minor | | @commercetools-frontend/permissions | Minor | | @commercetools-frontend/react-notifications | Minor | | @commercetools-frontend/sdk | Minor | | @commercetools-frontend/sentry | Minor | | @commercetools-frontend/url-utils | Minor | | @commercetools-local/visual-testing-app | Minor | | @commercetools-website/components-playground | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

gitstream-cm[bot] commented 3 months ago

This PR is missing a Jira ticket reference in the title or description. Please add a Jira ticket reference to the title or description of this PR.

gitstream-cm[bot] commented 3 months ago

🥷 Code experts: emmenko

dogayuksel has most 👩‍💻 activity in the files. emmenko, dogayuksel have most 🧠 knowledge in the files.

See details `.github/actions/test-template-action/action.yml` Activity based on git-commit: | | dogayuksel | | --- | --- | | JUN | | | MAY | 8 additions & 0 deletions | | APR | | | MAR | | | FEB | | | JAN | | Knowledge based on git-blame: dogayuksel: 8% emmenko: 1% `packages/mc-scripts/src/commands/build.ts` Activity based on git-commit: | | dogayuksel | | --- | --- | | JUN | | | MAY | | | APR | | | MAR | | | FEB | | | JAN | | Knowledge based on git-blame: emmenko: 99% `packages/mc-scripts/src/config/create-webpack-config-for-production.ts` Activity based on git-commit: | | dogayuksel | | --- | --- | | JUN | | | MAY | 10 additions & 2 deletions | | APR | | | MAR | | | FEB | | | JAN | | Knowledge based on git-blame: emmenko: 85% dogayuksel: 2% `packages/mc-scripts/src/vite-plugins/vite-plugin-i18n-message-compilation.ts` Activity based on git-commit: | | dogayuksel | | --- | --- | | JUN | | | MAY | 22 additions & 0 deletions | | APR | | | MAR | | | FEB | | | JAN | | Knowledge based on git-blame: dogayuksel: 100% `packages/mc-scripts/src/webpack-loaders/i18n-message-compilation-loader.ts` Activity based on git-commit: | | dogayuksel | | --- | --- | | JUN | | | MAY | 20 additions & 5 deletions | | APR | | | MAR | | | FEB | | | JAN | | Knowledge based on git-blame: dogayuksel: 100% `playground/.env` Activity based on git-commit: | | dogayuksel | | --- | --- | | JUN | | | MAY | 1 additions & 0 deletions | | APR | | | MAR | | | FEB | | | JAN | | Knowledge based on git-blame: emmenko: 30% dogayuksel: 10%

To learn more about /:\ gitStream - Visit our Docs