commercetools / merchant-center-application-kit

Tools and components for developing Merchant Center Customizations 🛠
https://docs.commercetools.com/merchant-center-customizations
MIT License
66 stars 27 forks source link

feat(create-mc-app): add cloudIdentifier flag #3564

Closed mustafaasif2 closed 1 week ago

mustafaasif2 commented 2 weeks ago

Summary

Added a cloudIdentifier flag for Custom Applications and Custom Views

Description

The create-mc-app CLI now prompts the user about the region of their choice, defaulting to gcp-eu.

The option to define the region is also be possible via a CLI option, e.g. --cloud-identifier=gcp-au for programmatic usage.

Background

Installing one of the Merchant Center starter templates (customizations) results by default in using the GCP EU environment.

However, for customers using a different CoCo region it might get confusing if they forget to change the cloudIdentifier to the region of their choice.

Corresponding Jira Ticket: SHIELD-1300

changeset-bot[bot] commented 2 weeks ago

🦋 Changeset detected

Latest commit: 8bda236fc07e66e84ee444eab02b1fb5acd956a7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages | Name | Type | | ----------------------------------------------------------------------------------- | ----- | | @commercetools-frontend/create-mc-app | Minor | | @commercetools-applications/merchant-center-template-starter-typescript | Minor | | @commercetools-applications/merchant-center-template-starter | Minor | | @commercetools-applications/merchant-center-custom-view-template-starter-typescript | Minor | | @commercetools-applications/merchant-center-custom-view-template-starter | Minor | | @commercetools-backend/eslint-config-node | Minor | | @commercetools-backend/express | Minor | | @commercetools-backend/loggers | Minor | | @commercetools-frontend/actions-global | Minor | | @commercetools-frontend/application-components | Minor | | @commercetools-frontend/application-config | Minor | | @commercetools-frontend/application-shell-connectors | Minor | | @commercetools-frontend/application-shell | Minor | | @commercetools-frontend/assets | Minor | | @commercetools-frontend/babel-preset-mc-app | Minor | | @commercetools-frontend/browser-history | Minor | | @commercetools-frontend/codemod | Minor | | @commercetools-frontend/constants | Minor | | @commercetools-frontend/cypress | Minor | | @commercetools-frontend/eslint-config-mc-app | Minor | | @commercetools-frontend/i18n | Minor | | @commercetools-frontend/jest-preset-mc-app | Minor | | @commercetools-frontend/jest-stylelint-runner | Minor | | @commercetools-frontend/l10n | Minor | | @commercetools-frontend/mc-dev-authentication | Minor | | @commercetools-frontend/mc-html-template | Minor | | @commercetools-frontend/mc-scripts | Minor | | @commercetools-frontend/notifications | Minor | | @commercetools-frontend/permissions | Minor | | @commercetools-frontend/react-notifications | Minor | | @commercetools-frontend/sdk | Minor | | @commercetools-frontend/sentry | Minor | | @commercetools-frontend/url-utils | Minor | | @commercetools-local/playground | Minor | | @commercetools-local/visual-testing-app | Minor | | @commercetools-website/components-playground | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mc-app-kit-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 10, 2024 7:39am
merchant-center-application-kit-components-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 10, 2024 7:39am
mustafaasif2 commented 2 weeks ago

Some general questions:

  1. Is the pipeline failing because of my changes or is it supposed to fail in the development environment. The error message that shows up is "Error: The operation was canceled."
  2. I tried generating a changeset file, however, I was not completely sure on the options to select while creating one for these changes.