commercetools / merchant-center-application-kit

Tools and components for developing Merchant Center Customizations 🛠
https://docs.commercetools.com/merchant-center-customizations
MIT License
66 stars 27 forks source link

feat: add `iconLeft` prop to `CustomFormDetailPage.FormPrimaryButton` #3565

Closed ragafus closed 1 week ago

ragafus commented 1 week ago

Summary

Screenshot 2024-07-08 at 18 19 44

Description

In @commercetools/priceless-team-fe, we have a design where CustomFormDetailPage.FormPrimaryButton and CustomFormDetailPage.FormSecondaryButton have an icon (see screenshots https://commercetools.atlassian.net/browse/PRC-3533). Currently CustomFormDetailPage.FormPrimaryButton does not accept an iconLeft prop (CustomFormDetailPage.FormSecondaryButton does)

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mc-app-kit-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 8, 2024 4:28pm
merchant-center-application-kit-components-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 8, 2024 4:28pm
changeset-bot[bot] commented 1 week ago

🦋 Changeset detected

Latest commit: 6d7288ba9239d1aed93748dac2ae155d46a064bc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages | Name | Type | | ----------------------------------------------------------------------------------- | ----- | | @commercetools-frontend/application-components | Minor | | @commercetools-frontend/application-shell | Minor | | @commercetools-frontend/codemod | Minor | | @commercetools-frontend/mc-scripts | Minor | | @commercetools-frontend/react-notifications | Minor | | @commercetools-applications/merchant-center-template-starter-typescript | Minor | | @commercetools-applications/merchant-center-template-starter | Minor | | @commercetools-applications/merchant-center-custom-view-template-starter-typescript | Minor | | @commercetools-applications/merchant-center-custom-view-template-starter | Minor | | @commercetools-local/playground | Minor | | @commercetools-local/visual-testing-app | Minor | | @commercetools-website/components-playground | Minor | | @commercetools-frontend/cypress | Minor | | @commercetools-backend/eslint-config-node | Minor | | @commercetools-backend/express | Minor | | @commercetools-backend/loggers | Minor | | @commercetools-frontend/actions-global | Minor | | @commercetools-frontend/application-config | Minor | | @commercetools-frontend/application-shell-connectors | Minor | | @commercetools-frontend/assets | Minor | | @commercetools-frontend/babel-preset-mc-app | Minor | | @commercetools-frontend/browser-history | Minor | | @commercetools-frontend/constants | Minor | | @commercetools-frontend/create-mc-app | Minor | | @commercetools-frontend/eslint-config-mc-app | Minor | | @commercetools-frontend/i18n | Minor | | @commercetools-frontend/jest-preset-mc-app | Minor | | @commercetools-frontend/jest-stylelint-runner | Minor | | @commercetools-frontend/l10n | Minor | | @commercetools-frontend/mc-dev-authentication | Minor | | @commercetools-frontend/mc-html-template | Minor | | @commercetools-frontend/notifications | Minor | | @commercetools-frontend/permissions | Minor | | @commercetools-frontend/sdk | Minor | | @commercetools-frontend/sentry | Minor | | @commercetools-frontend/url-utils | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

gitstream-cm[bot] commented 1 week ago

🥷 Code experts: emmenko

emmenko has most 🧠 knowledge in the files.

See details `packages/application-components/src/components/internals/default-form-buttons.tsx` Knowledge based on git-blame: emmenko: 11%

To learn more about /:\ gitStream - Visit our Docs