commercetools / nodejs

Everything related to the Node.js ecosystem for the commercetools platform.
https://commercetools.github.io/nodejs/
MIT License
75 stars 70 forks source link

Documentation - SDK Middleware Http #1697

Closed ajimae closed 3 years ago

ajimae commented 3 years ago

Summary

Description

Expand on the already existing documentation on abortController, add usage examples and point out the difference between abortController and getAbortController

Todo

codecov[bot] commented 3 years ago

Codecov Report

Merging #1697 (588f749) into master (523fd3e) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1697   +/-   ##
=======================================
  Coverage   98.65%   98.65%           
=======================================
  Files         128      128           
  Lines        3427     3427           
  Branches      791      791           
=======================================
  Hits         3381     3381           
  Misses         42       42           
  Partials        4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 523fd3e...588f749. Read the comment docs.

barbara79 commented 3 years ago

It looks good to me 🥇 just a small comment on my side ;)

ajimae commented 3 years ago

Thanks @ajimae , looks pretty good, just one comment, why there is changes in yarn.lock?

I ran yarn install when I checkout the master branch.

I will revert on changes in the yarn lock accordingly.