commercetools / nodejs

Everything related to the Node.js ecosystem for the commercetools platform.
https://commercetools.github.io/nodejs/
MIT License
75 stars 70 forks source link

Reduce Token Fetch Window #1805

Closed ajimae closed 2 years ago

ajimae commented 2 years ago

Summary

Description

Reduce the window period the SDK should fetch a new token to accommodate for the new 1 hours token validity period.

Related Issues

Jira

changeset-bot[bot] commented 2 years ago

🦋 Changeset detected

Latest commit: e7980e5339130398401da5e80ca739d3a156fbcb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ---------------------------------- | ----- | | @commercetools/sdk-middleware-auth | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov[bot] commented 2 years ago

Codecov Report

Merging #1805 (e7980e5) into master (f6e1ba1) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1805   +/-   ##
=======================================
  Coverage   94.62%   94.62%           
=======================================
  Files         139      139           
  Lines        4854     4854           
  Branches     1328     1328           
=======================================
  Hits         4593     4593           
  Misses        258      258           
  Partials        3        3           
Impacted Files Coverage Δ
packages/sdk-middleware-auth/src/base-auth-flow.js 94.39% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

ajimae commented 2 years ago

Thanks Cant comment on the userOptions change. Expiration looks good

It's code formatting, let me revert it.

Thanks