search

commercetools / nodejs

Everything related to the Node.js ecosystem for the commercetools platform.
https://commercetools.github.io/nodejs/
MIT License
75 stars 70 forks source link

feat(sync-actions): add support for quotes #1813

Closed leventekobor closed 1 year ago

leventekobor commented 2 years ago

Summary

Quotes sync action coverage. link to docs

Description

changeset-bot[bot] commented 2 years ago

⚠️ No Changeset found

Latest commit: 30e6f03b2477e6800bde9d1604355180b668d04f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

codecov[bot] commented 2 years ago

Codecov Report

Merging #1813 (30e6f03) into master (737c4a6) will increase coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1813      +/-   ##
==========================================
+ Coverage   94.62%   94.64%   +0.01%     
==========================================
  Files         139      141       +2     
  Lines        4857     4875      +18     
  Branches     1331     1332       +1     
==========================================
+ Hits         4596     4614      +18     
  Misses        258      258              
  Partials        3        3
Impacted Files Coverage Δ
packages/sync-actions/src/quotes-actions.js 100.00% <100.00%> (ø)
packages/sync-actions/src/quotes.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

YahiaElTai commented 2 years ago

@leventekobor would be great if you ask someone from the team owning this to review just to make sure things are okay, from the checkout side, this looks really good! Thanks a lot <3