commercetools / nodejs

Everything related to the Node.js ecosystem for the commercetools platform.
https://commercetools.github.io/nodejs/
MIT License
75 stars 70 forks source link

fix(sync-actions/orders): adjust diff calculation of returnInfo items #1818

Closed qmateub closed 1 year ago

qmateub commented 1 year ago

Summary

As in my previous PR, Audit Log does a heavy usage of sync actions for getting the diff between versions of the same entity.

For one of the events we were having some issues with how sync actions was calculating the diff for an order.

Description

This time we have found an event that was returning an error from the sync actions library. It was related to the way we calculated the diff inside returnInfo.

The first commit contains a test case in which the error will show up. The second commit contains the proposed fix.

Let me know your thoughts 🙏

Todo

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: 4290f7443011c1168d4debf3687e51a02215f59e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | --------------------------- | ----- | | @commercetools/sync-actions | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov[bot] commented 1 year ago

Codecov Report

Merging #1818 (4290f74) into master (fe12dfa) will decrease coverage by 0.02%. The diff coverage is 88.88%.

@@            Coverage Diff             @@
##           master    #1818      +/-   ##
==========================================
- Coverage   94.68%   94.66%   -0.03%     
==========================================
  Files         145      145              
  Lines        4913     4908       -5     
  Branches     1334     1334              
==========================================
- Hits         4652     4646       -6     
- Misses        258      259       +1     
  Partials        3        3              
Impacted Files Coverage Δ
packages/sync-actions/src/order-actions.js 96.87% <88.88%> (-1.68%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.