commercetools / nodejs

Everything related to the Node.js ecosystem for the commercetools platform.
https://commercetools.github.io/nodejs/
MIT License
75 stars 70 forks source link

sync actions for attribute group #1876

Closed jaikumar-tj closed 1 year ago

jaikumar-tj commented 1 year ago

Summary

Sync action for attribute groups.

Description

The Attribute groups feature was released to the public beta and this PR creates the necessary sync action.

Todo

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: e36d98f2a7ffac5e6907aa0a75ba8619e9e167b9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | --------------------------- | ----- | | @commercetools/sync-actions | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov[bot] commented 1 year ago

Codecov Report

Merging #1876 (e36d98f) into master (470456f) will increase coverage by 0.03%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1876      +/-   ##
==========================================
+ Coverage   94.69%   94.73%   +0.03%     
==========================================
  Files         145      147       +2     
  Lines        4997     5031      +34     
  Branches     1365     1371       +6     
==========================================
+ Hits         4732     4766      +34     
  Misses        262      262              
  Partials        3        3              
Impacted Files Coverage Δ
...kages/sync-actions/src/attribute-groups-actions.js 100.00% <100.00%> (ø)
packages/sync-actions/src/attribute-groups.js 100.00% <100.00%> (ø)
jaikumar-tj commented 1 year ago

@tdeekens Do I need anyone else's approval? Do I need to add a changeset? I'm not sure about the procedure for this repo.

tdeekens commented 1 year ago

@tdeekens Do I need anyone else's approval? Do I need to add a changeset? I'm not sure about the procedure for this repo.

  1. Yes, you need a changeset.
  2. Other approvals aren't needed.
  3. You can release (by merging the PR) after.
jaikumar-tj commented 1 year ago

@tdeekens Could you help me here? I don't have permission to merge PR.

Screenshot 2023-07-20 at 08 25 52