search

commercetools / nodejs

Everything related to the Node.js ecosystem for the commercetools platform.
https://commercetools.github.io/nodejs/
MIT License
75 stars 70 forks source link

chore: to replace fs.access with fs.exist #1890

Open Rombelirk opened 4 months ago

Rombelirk commented 4 months ago

Relates to

changeset-bot[bot] commented 4 months ago

⚠️ No Changeset found

Latest commit: f6c38b6168269ada2307c1d88fdf676a48f3dbfe

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.75%. Comparing base (f8e1857) to head (f6c38b6). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1890 +/- ## ======================================= Coverage 94.75% 94.75% ======================================= Files 147 147 Lines 5057 5057 Branches 1375 1375 ======================================= Hits 4792 4792 Misses 262 262 Partials 3 3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ajimae commented 3 months ago

Also, to make the testing easier, I will suggest you move doesFileExist as an exported function into a util or helper file and import them everywhere else where it is used.