search

commercetools / rmf-codegen

Provides RAML code generators based on RMF.
Apache License 2.0
13 stars 7 forks source link

DEVX-404 adding a docblock in the clientcredential #319

Closed barbara79 closed 4 months ago

barbara79 commented 5 months ago

adding a docblock in the ClientCredential class class https://commercetools.atlassian.net/jira/software/c/projects/DEVX/boards/386?selectedIssue=DEVX-404

gitstream-cm[bot] commented 5 months ago

🥷 Code experts: jenschude

jenschude has most 🧠 knowledge in the files.

See details `languages/php/src/main/kotlin/io/vrap/codegen/languages/php/base/PhpBaseFileProducer.kt` Knowledge based on git-blame: jenschude: 99%

To learn more about /:\ gitStream - Visit our Docs

jenschude commented 5 months ago

LGTM 👍

I'm wondering if this is an error of the SDK or of the API 🤔 From the linked issue it seems like an error of the API that you cannot provide scope when there is only 1 scope. If so, this should be updated also in the documentations: docs.commercetools.com/api/scopes. Please clarify 🙏

It's actually a bad practice to use an oauth client with multiple scopes and request a token with a fraction of them. It's always better to create an oauth client with the scopes needed and than just omit the scopes in the oauth request.

barbara79 commented 5 months ago

LGTM 👍 I'm wondering if this is an error of the SDK or of the API 🤔 From the linked issue it seems like an error of the API that you cannot provide scope when there is only 1 scope. If so, this should be updated also in the documentations: docs.commercetools.com/api/scopes. Please clarify 🙏

It's actually a bad practice to use an oauth client with multiple scopes and request a token with a fraction of them. It's always better to create an oauth client with the scopes needed and than just omit the scopes in the oauth request.

Thanks for the clarification @jenschude !