search

commercetools / sphere-play-sdk

Java API client and helper classes for building a SPHERE.IO shop on Play 2.2
http://sphere.io
7 stars 6 forks source link

Provide detailed discount information #107

Closed butenkor closed 10 years ago

butenkor commented 10 years ago

Currently https://github.com/commercetools/sphere-play-sdk/blob/master/java-client/src/main/java/io/sphere/client/shop/model/Discount.java is a draft and has no attributes. Would be great to know details like discount type (absolute / relative) its value, name.

schleichardt commented 10 years ago

@gogregor Does reference expansion for discounts work already in the backend?

gogregor commented 10 years ago

no, but it will be added this week.

gogregor commented 10 years ago

tomorrow we will add the discount documentation to http://dev.sphere.io/.

butenkor commented 10 years ago

:+1:

salander commented 10 years ago

@gogregor would be nice to can filter by discounted products. is that possible? if not maybe you can provide something in the sdk @schleichardt ?

gogregor commented 10 years ago

@salander thanks for the suggestion, I added it to our search feature list.

dteubert commented 10 years ago

What is the status?

mmoelli commented 10 years ago

@schleichardt will implement this tomorrow.

schleichardt commented 10 years ago

I have now the production code and tests, but I can't release because of https://github.com/commercetools/ops-automation/issues/176 .

schleichardt commented 10 years ago

see https://github.com/commercetools/sphere-play-sdk/releases/tag/v0.65.0