commercetools / sunrise-spa

SUNRISE shop template as a single-page application
https://sunrise-spa.now.sh
Apache License 2.0
51 stars 78 forks source link

Keep in store locale, country and currency #151

Closed lauraluiz closed 5 years ago

lauraluiz commented 5 years ago
zeina-idris commented 5 years ago

I guess this fixes issue #147 ?

lauraluiz commented 5 years ago

@zeina-idris @plaskevich I have fixed the tests, please check the change as they are not trivial. Due to the fact that now country/currency is selected and added to the cart, the prices shown are applying taxes, which is more correct (before they weren't). Also, I've made sure the location selector closes the moment you select a language.

lauraluiz commented 5 years ago

I guess this fixes issue #147 ?

Not completely. This PR only allows to configure country/currency/languages. What the issue mentions is that we should fetch this information from the API, and fallback to the configured ones when it's not available. So let's say this PR does 25% of the issue :P