search

commercetools / sunrise-spa

SUNRISE shop template as a single-page application
https://sunrise-spa.now.sh
Apache License 2.0
51 stars 78 forks source link

Danu #251

Closed danudevphoton closed 3 years ago

danudevphoton commented 3 years ago

Checklist

vercel[bot] commented 3 years ago

@photon-learning is attempting to deploy a commit to the commercetools Team on Vercel.

A member of the Team first needs to authorize it.

harm-meijer commented 3 years ago

Thank you Ucu and Danu for your pull request,

However; I cannot merge this with master as it fails unit and end to end tests and it will change the look/languages of the demo.

If your sunrise config is different from the standard demo then there is a way to provide a local config to override some configs.

If your demo needs different components you can set an environment variable and optionally load your component based on this variable. Require doesn't always work, in that case you can use a path resolve to dynamically load your specific component based on environment variables.