Closed ragafus closed 1 month ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
ui-kit | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jul 22, 2024 3:31pm |
Latest commit: 5ebceb001449ae12b50e4881e6a8c16d4f70d8a7
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
This PR is missing a Jira ticket reference in the title or description. Please add a Jira ticket reference to the title or description of this PR.
🥷 Code experts: emmenko
emmenko has most 👩💻 activity in the files. emmenko, Rhotimee have most 🧠 knowledge in the files.
To learn more about /:\ gitStream - Visit our Docs
Hey @misama-ct @ddouglasz, I've refactored the code as we agreed in the meeting. Please, let me know your thoughts.
Please note that we would also need a sign off from our designer @FilPob too.
Thanks for taking the time to do this change.
@FilPob you can provoke the error-message by setting a min and/or max value here, entering a number out of the min/max range in the input and then checking the "touched" checkbox.
Thanks! Looks good from my side
Summary
Adds two new error keys,
belowMin
andaboveMax
, to improveNumberField
DX.Description
NumberField
provides amin
andmax
props which are used as property on input field. Unfortunately, users can introduce numbers above themax
prop and below themin
props. ATM, the developer usingNumberField
has to handle all the logic regardingmin
andmax
errors. With this PR we provide default error messages forbelowMin
andaboveMax
error keys, so, the developer usingNumberField
has to just generate these new keys when validating their forms.