search

commercetools / ui-kit

Component library 💅
https://uikit.commercetools.com
MIT License
145 stars 25 forks source link

chore: bring back the cookie banner in storybook #2897

Closed misama-ct closed 1 month ago

misama-ct commented 1 month ago

Summary

The cookie banner got lost since it was added only recently during the migration process. This PR restores it.

Description

When talking with @jaikamat I was made a ware that we have a package for dealing with the cookiebanner, I tried to use it, but unfortunately I could not find a non-hacky way to integrate React components into the storybook app itself, so this initial implementation (which we used in the former storybook) will have to do for now.

I'll do some more investigation once I am working on the UserGuidance survey implementation (as the UserGuidance snippet should only be loaded if the user gave consent via the banner).

[!NOTE]
If you want to see the cookie banner in action, here is the comment explaining how

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui-kit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 12, 2024 7:27am
ui-kit-storybook-v8 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 12, 2024 7:27am
changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: a91423d0b91dde2de18bfa0243ac2364e59d2135

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR