commercetools / ui-kit

Component library 💅
https://uikit.commercetools.com
MIT License
145 stars 25 forks source link

FCT-1182 - Filters - Implement initial `FiltersList` API and styling #2966

Closed valoriecarli closed 1 month ago

valoriecarli commented 1 month ago

Ticket reference Figma spec

Requirements Summary:

** ['local-dev'] left for testing purposes & will be commented out prior to merging.

Screenshot 2024-10-16 at 14 10 37 Screenshot 2024-10-16 at 14 11 38 Screenshot 2024-10-17 at 16 05 22
changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: 92665c85cbe28d4a08f736aaef5b3647b4b49356

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui-kit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2024 4:07pm
valoriecarli commented 1 month ago

Overall looks good, just a few small changes and a nit about declaring buttons

@ByronDWall thank you so much! all suggestions have been applied.

FilPob commented 1 month ago

Could we maybe squeeze in an animation for the showing & hiding of the filters? we have the collapsible motion component that could help