Closed valoriecarli closed 1 month ago
Latest commit: 92665c85cbe28d4a08f736aaef5b3647b4b49356
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
ui-kit | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Oct 18, 2024 4:07pm |
Overall looks good, just a few small changes and a nit about declaring buttons
@ByronDWall thank you so much! all suggestions have been applied.
Could we maybe squeeze in an animation for the showing & hiding of the filters? we have the collapsible motion component that could help
Ticket reference Figma spec
Requirements Summary:
filters
,add filter
&clear all
buttons, horizontal & vertical dividerAdd Filter
button should use radix/popover to expand a SelectInput component to allow for selecting filters.**
['local-dev']
left for testing purposes & will be commented out prior to merging.