search

commercetools / ui-kit

Component library 💅
https://uikit.commercetools.com
MIT License
145 stars 25 forks source link

Migrate CopyToClipboard component #587

Open emmenko opened 5 years ago

emmenko commented 5 years ago

We have internally a <CopyToClipboard> component that we use in different places.

I think this would be a good fit for a ui-kit component.

I just want to track this issue first, there is no real need for this for now.

tdeekens commented 5 years ago

What would be the arguments for UIKit over having it in application-components? Just curious how we would phrase that line of argument where it may belong. As UIKit attempts to be a Design System, having something which has not visual representation in it, may feel a bit odd.

emmenko commented 5 years ago

In app-components, I would put stuff that is specific to building applications. A copy-to-clipboard can be used anywhere (e.g. docs websites to copy code snippets)

adnasa commented 3 years ago

Setting this to on hold given that shield team are focusing on other topics Will include it as part of v13 candidate of components

mmaltsev-ct commented 2 years ago

Let's have another discussion regarding why it should be a part of the ui-kit.