search

commercialhaskell / curator

Haskell Stackage curator build tool
Other
8 stars 8 forks source link

Doesn't consider internal libraries? #41

Open tfausak opened 5 months ago

tfausak commented 5 months ago

I was recently pinged to update one of my packages (burrito) to allow QuickCheck 2.15: https://github.com/commercialhaskell/stackage/issues/7391

Curiously I wasn't pinged to update another one of my packages (saturn), even though it's also in Stackage and depends on QuickCheck < 2.15. After thinking about it for a minute, I realized that saturn depends on QuickCheck in one of its internal libraries (namely saturn:lib:spec): https://github.com/tfausak/saturn/blob/1.0.0.3/saturn.cabal#L81

Is that a problem for this curator tool? I wasn't sure where to report this issue.

mihaimaruseac commented 5 months ago

There is some long-standing Stack issue, I think. We have https://github.com/commercialhaskell/stackage/issues/4475 for curator and https://github.com/commercialhaskell/stack/issues/4148 on stack. Maybe more, but these are the ones I know of, I need to find some long time to look into them

mpilgrem commented 5 months ago

https://github.com/commercialhaskell/stack/issues/4148 is specific to stack ghci. stack build 'proper' should work with sub-libraries, since Stack 2.15.1. However, you can't specify a public sub-library as an isolated build target with Stack, because Stack still approaches building in terms of 'packages (with components)' rather than 'components (of packages)'.