search

commercialhaskell / hi-file-parser

Other
4 stars 4 forks source link

Fix #4 Allow dependency on mtl >= 2.3 #6

Closed mpilgrem closed 2 years ago

mpilgrem commented 2 years ago

From mtl-2.3, Control.Monad.State no longer re-exports Control.Monad.when.

Also avoids warning in respect of the Data.Semigroup import.

Also bumps stack.yaml to a recent version of GHC (as earlier version fails on Windows).

Tested by building with Stack with a dependency on mtl-2.3.

mpilgrem commented 2 years ago

@snoyberg, I do not know why all the CI was 'cancelled' but I have tested this pull request on Windows with GHC 9.0.2.

snoyberg commented 2 years ago

No idea why, but switching to GitHub Actions is probably a good idea regardless.

mpilgrem commented 2 years ago

@snoyberg, I should have been express: could this pull request be considered for merger by you, not withstanding the cancelled CI? (I do not have commit rights for this repository and I noted it was you who had merged all past pull requests.) EDIT: Scratch that request, I must have been mistaken, I now have commit rights.

I think converting the CI to use GitHub Actions is within my capabilities. I will look at that separately.