search

commercialhaskell / path

Typed filepath
Other
122 stars 45 forks source link

Binary instance #158

Closed locallycompact closed 4 years ago

locallycompact commented 4 years ago

Hi, I'm trying to use Path in Shake oracle rules but shake expects a Binary instance for its Rule type. Has the binary instance been left out on purpose or can this be added?

NorfairKing commented 4 years ago

It's been left out so that there doesn't need to be a dependency on any particular serialisation library. Which Binary are you talking about?

locallycompact commented 4 years ago

The one in this. https://hackage.haskell.org/package/shake-0.18.5/docs/Development-Shake-Classes.html

Sorry I guess I assumed this was kid of a stock thing. That's ok don't worry about it.

NorfairKing commented 4 years ago

I assumed this was kid of a stock thing.

It's not, but I once made the same assumption. Don't worry about it. Feel free to close this issue if you think we're done here.