search

commercialhaskell / rio

A standard library for Haskell
Other
838 stars 54 forks source link

Warnings #190

Closed fosskers closed 3 years ago

fosskers commented 5 years ago

This PR turns on the canonical warning flags recommended by RIO, and fixes what's revealed.

Note: I'm getting these strange warnings left over.

/home/colin/code/haskell/rio/rio/src/RIO/Prelude.hs:3:5-28: warning: [-Wdodgy-exports]
    The export item ‘module RIO.Prelude.Types’ exports nothing
  |
3 |     module RIO.Prelude.Types
  |     ^^^^^^^^^^^^^^^^^^^^^^^^
/home/colin/code/haskell/rio/rio/src/RIO/Prelude.hs:386:1-34: warning: [-Wunused-imports]
    The qualified import of ‘RIO.Prelude.Types’ is redundant
    |
386 | import qualified RIO.Prelude.Types
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

despite the fact that RIO.Prelude.Types clearly exports a lot. Throwing NoImplicitPrelude around doesn't seem to help. I'm going to test elsewhere whether this is a bug with -Wdodge-exports.

fosskers commented 5 years ago

https://gitlab.haskell.org/ghc/ghc/issues/16856

snoyberg commented 5 years ago

+1 on the overall change, but it would be much easier to follow without a bunch of whitespace-only changes included at the same time.

fosskers commented 5 years ago

Probably easiest to fix this up once/if the others are merged.