commercialhaskell / stackage

Stable Haskell package sets: vetted consistent packages from Hackage
https://www.stackage.org/
MIT License
530 stars 805 forks source link

criterion-1.2 out of bounds #2538

Closed mihaimaruseac closed 7 years ago

mihaimaruseac commented 7 years ago

It was recently updated

criterion-1.2.0.0 is out of bounds for:

Gabriella439 commented 7 years ago

Fixed in bench-1.0.4

zohl commented 7 years ago

Fixed in dictionaries-0.2.0.2

bergmark commented 7 years ago

Worth re-checking this wrt #2542

mihaimaruseac commented 7 years ago

After #2542:

criterion-1.2.0.0 is out of bounds for:

mrkkrp commented 7 years ago

New revisions published for:

fosskers commented 7 years ago

vectortiles fixed.

basvandijk commented 7 years ago

Thanks for the notice. case-insensitive, lifted-base and scientific are fixed.

hvr commented 7 years ago

For the record, I'm going to maintain my packages' benchmark suites only when there's already another reason to make a new release as I see no benefit to inflate the package index with revisions for no good reason, and just for an optional component which doesn't even affect the install plan solving anyway (and moreover, we may soon have independent per-component solving, so there'll be even less need to keep components solvable with a shared install-plan).

agrafix commented 7 years ago
christiaanb commented 7 years ago

I've updated the .cabal file for clash-prelude-0.11.2 on hackage with the correct bounds

nikita-volkov commented 7 years ago

I join @hvr. Please ignore the dependency check of the Test and Benchmark suites of my packages.

ivan-m commented 7 years ago

I also agree with @hvr

fosskers commented 7 years ago

Is there an issue open for that? Doesn't seem like there's an issue open for discussing that. It seems like a sensible idea.

DanBurton commented 7 years ago

If you would like us to skip building your packages' tests and/or benchmarks, you can open a PR that adds your packages to the skipped-tests and skipped-benchmarks sections of build-constraints.yaml.

See: https://github.com/fpco/stackage/blob/8b5f88c12566a1e2588748b6114ba12d89d752d9/build-constraints.yaml#L3767

mihaimaruseac commented 7 years ago

Closing in favor of #2604 as there is a new version of criterion released