search

commercialhaskell / stackage

Stable Haskell package sets: vetted consistent packages from Hackage
https://www.stackage.org/
MIT License
530 stars 807 forks source link

genvalidity-persistent fails to compile with GHC 8.10.4 #5903

Closed mihaimaruseac closed 3 years ago

mihaimaruseac commented 3 years ago 
    Configuring genvalidity-persistent-0.0.0.0...
    Preprocessing library for genvalidity-persistent-0.0.0.0..
    Building library for genvalidity-persistent-0.0.0.0..
    [1 of 2] Compiling Data.GenValidity.Persist
    [2 of 2] Compiling Paths_genvalidity_persistent
    Preprocessing test suite 'genvalidity-persistent-test' for genvalidity-persistent-0.0.0.0..
    Building test suite 'genvalidity-persistent-test' for genvalidity-persistent-0.0.0.0..
    [1 of 3] Compiling Data.GenValidity.PersistSpec

    /var/stackage/work/unpack-dir/unpacked/genvalidity-persistent-0.0.0.0-3ba7908d36bbaae630865908727a82b8e499bd746e0a42e13e0759f813d8f16b/test/Data/GenValidity/PersistSpec.hs:27:1: error:
        Generating Persistent entities now requires the following language extensions:

    DataKinds
    FlexibleInstances

    Please enable the extensions by copy/pasting these lines into the top of your file:

    {-# LANGUAGE DataKinds #-}
    {-# LANGUAGE FlexibleInstances #-}
       |
    27 | share
       | ^^^^^...

Will skip testing for now

CC @NorfairKing

mihaimaruseac commented 3 years ago

Benchmarks also fail

    Building benchmark 'genvalidity-persistent-bench' for genvalidity-persistent-0.0.0.0..
    [1 of 2] Compiling Main

    /var/stackage/work/unpack-dir/unpacked/genvalidity-persistent-0.0.0.0-3ba7908d36bbaae630865908727a82b8e499bd746e0a42e13e0759f813d8f16b/bench/Main.hs:26:1: error:
        Generating Persistent entities now requires the DataKinds language extension. Please enable it by copy/pasting this line to the top of your file:

    {-# LANGUAGE DataKinds #-}
       |
    26 | share
       | ^^^^^...
NorfairKing commented 3 years ago

@mihaimaruseac I think I can't test with GHC 9 until there's a nightly snapshot that supports it (and a nixpkgs commit that uses that snapshot).

mihaimaruseac commented 3 years ago

I was wrong, the build was still using GHC 8.10.4

bergmark commented 3 years ago

Closing this due to the GHC 9 upgrade. Packages mentioned here may have been disabled, please see https://github.com/commercialhaskell/stackage/issues/6072 for more information.