commercialhaskell / stackage

Stable Haskell package sets: vetted consistent packages from Hackage
https://www.stackage.org/
MIT License
530 stars 805 forks source link

htoml gets a new upper bound on tasty-hspec-1.2 via a revision on Hackage and breaks Stackage #6239

Closed mihaimaruseac closed 2 years ago

mihaimaruseac commented 3 years ago

tasty-hspec-1.2 (changelog) (Mitchell Rosen mitchellwrosen@gmail.com @mitchellwrosen) is out of bounds for:

In this case, the upper bound has been added today by @Bodigrim in a revision.

For now, will disable testing for htoml until the upper bound can be relaxed without breakages(?)

Bodigrim commented 3 years ago

htoml-1.0.0.3 test suite is incompatible with tasty-hspec-1.2:

test/Text/Toml/Parser/Spec.hs:26:3: error:
    Variable not in scope:
      describe
        :: t1
           -> m0 b0 -> hspec-core-2.8.3:Test.Hspec.Core.Spec.Monad.SpecM () a0
   |
26 |   describe "Parser.tomlDoc generic" $ do
   |   ^^^^^^^^

test/Text/Toml/Parser/Spec.hs:28:5: error:
    • Variable not in scope: it :: t2 -> Bool -> m0 a1
    • Perhaps you meant ‘id’ (imported from Prelude)
   |
28 |     it "should parse empty input" $
   |     ^^
...

I don't understand how it used to build before.

mitchellwrosen commented 3 years ago

It used to build before because tasty-hspec used to re-export symbols defined by hspec (it, describe).

Bodigrim commented 3 years ago

Correct, my question is how, for instance, nightly-2021-10-12 was able to accomodate both htoml-1.0.0.3 and tasty-hspec-1.2 prior to my revision without disabling htoml test suite? There should have been build failures.

bergmark commented 3 years ago

I suspect that there are some issues with cache invalidation in our stack workspace. The test may not have run properly the first time, but the revision caused a bounds failure (which is reliable).

bergmark commented 2 years ago

We're closing this since we upgraded to GHC 9.2.2. Packages that hadn't been updated have been disabled. If so, they are listed in https://github.com/commercialhaskell/stackage/issues/6486. If only tests/benchmarks are disabled you can find mentions of that under skipped-test, expected-test-failures, or expected-benchmark in build-constraints.yaml.