commercialhaskell / stackage

Stable Haskell package sets: vetted consistent packages from Hackage
https://www.stackage.org/
MIT License
530 stars 805 forks source link

re-disable some NorfairKing packages #7139

Closed jkachmar closed 1 year ago

jkachmar commented 1 year ago
errors ``` error: [GHC -88464] Variable not in scope: forM_ :: [MatchHeader] -> (MatchHeader -> IO ()) -> IO a0 | 94 | forM_ matchHeaders $ \(MatchHeader matchHeaderFunc) -> | ^^^^^ ```
errors ``` src/Data/Validity/URI.hs:79:15: error: [GHC-88464] Variable not in scope: decorateString :: [Char] -> (Char -> Validation) -> Validation | 79 | decorateString | ^^^^^^^^^^^^^^ ```
errors ``` src/Data/Appendful/Persistent.hs:227 :5: error: [GHC-39999] • Could not deduce ‘SafeToInsert clientRecord’ arising from a use of ‘insert_’ from the context: (PersistEntity clientRecord, PersistEntityBackend clientRecord ~ SqlBackend, MonadIO m) bound by the type signature for: setupClientQuery :: forall clientRecord (m :: * -> *) a sid. (PersistEntity clientRecord, PersistEntityBackend clientRecord ~ SqlBackend, MonadIO m) => (a -> clientRecord) -> (sid -> a -> clientRecord) -> ClientStore (Key clientRecord) sid a -> SqlPersistT m () at src/Data/Appendful/Persistent.hs:(210,1)-(220,18) Possible fix: add (SafeToInsert clientRecord) to the context of the type signature for: setupClientQuery :: forall clientRecord (m :: * -> *) a sid. (PersistEntity clientRecord, PersistEntityBackend clientRecord ~ SqlBackend, MonadIO m) => (a -> clientRecord) -> (sid -> a -> clientRecord) -> ClientStore (Key clientRecord) sid a -> SqlPersistT m () ```
errors *) a sid. (PersistEntity clientRecord, PersistEntityBackend clientRecord ~ SqlBackend, MonadIO m) => (a -> clientRecord) -> (sid -> a -> clientRecord) -> (sid -> clientRecord) -> ClientStore (Key clientRecord) sid a -> SqlPersistT m () at src/Data/Mergeless/Persistent.hs:(242,1)-(254,18) Possible fix: add (SafeToInsert clientRecord) to the context of the type signature for: setupClientQuery :: forall clientRecord (m :: * -> *) a sid. (PersistEntity clientRecord, PersistEntityBackend clientRecord ~ SqlBackend, MonadIO m) => (a -> clientRecord) -> (sid -> a -> clientRecord) -> (sid -> clientRecord) -> ClientStore (Key clientRecord) sid a -> SqlPersistT m () • In the expression: insert_ (funcS sid st) In the second argument of ‘($)’, namely ‘\ (sid, st) -> insert_ (funcS sid st)’ In a stmt of a 'do' block: forM_ (M.toList clientStoreSynced) $ \ (sid, st) -> insert_ (funcS sid st) | 261 | insert_ (funcS sid st) | ^^^^^^^ ```
errors (Text -> SqlPersistM ()) -> ReaderT SqlBackend (monad-logger-0.3.40:Control.Monad.Logger.NoLoggingT (resourcet-1.3.0:Control.Monad.Trans.Resource.Internal.ResourceT IO)) a0 | 122 | forM_ statements $ \statement -> | ```
errors ``` src/Test/Syd/Hspec.hs:30:42: error: [G HC-83865] • Couldn't match type ‘transformers-0.6.1.0:Control.Monad.Trans.Reader.ReaderT hspec-core-2.11.5:Test.Hspec.Core.Spec.Monad.Env IO’ with ‘IO’ Expected: WriterT (base-4.18.1.0:Data.Semigroup.Internal.Endo hspec-core-2.11.5:Test.Hspec.Core.Config.Definition.Config, [Hspec.SpecTree ()]) IO () Actual: WriterT (base-4.18.1.0:Data.Semigroup.Internal.Endo hspec-core-2.11.5:Test.Hspec.Core.Config.Definition.Config, [Hspec.SpecTree ()]) (transformers-0.6.1.0:Control.Monad.Trans.Reader.ReaderT hspec-core-2.11.5:Test.Hspec.Core.Spec.Monad.Env IO) () • In the first argument of ‘runWriterT’, namely ‘specWriter’ In the second argument of ‘($)’, namely ‘runWriterT specWriter’ In a stmt of a 'do' block: (result, trees) <- liftIO $ runWriterT specWriter | 30 | (result, trees) <- liftIO $ runWriterT specWriter | ```
errors ``` test/Data/Mergeful/CollectionSp ec.hs:718:17: error: [GHC-88464] Variable not in scope: unless :: Bool -> Expectation -> f0 () | 718 | unless | ^^^^^^ ```

note: the error snippets aren't comprehensive, just a single example pulled from the logs to demonstrate that there are some compile failures which appear to be associated with incompatible dependency bounds on these packages

jkachmar commented 1 year ago

@NorfairKing

NorfairKing commented 1 year ago

@jkachmar on it

NorfairKing commented 1 year ago

@jachmar, the validity-network-uri should be fixed. There was a missing upload of a newer validity.

I can't figure out how to test the rest in CI :(

NorfairKing commented 1 year ago

Looks like I'll have to end up taking all my packages out of stackage, because I just don't have a way to try reproducing these failures in my CI.

NorfairKing commented 1 year ago

All except appendful and mergeful should be fixed already now.

NorfairKing commented 1 year ago

These should all be fixed now. I also left a comment on https://github.com/commercialhaskell/stackage/issues/7140#issuecomment-1753172875

alaendle commented 1 year ago

@NorfairKing Still seeing...

Building test suite 'mergeful-test' for genvalidity-mergeful-0.3.0.0..
[1 of 6] Compiling Data.Mergeful.CollectionSpec

/home/andreas/stackage/stackage/tmp.qMvk/genvalidity-mergeful-0.3.0.0/test/Data/Mergeful/CollectionSpec.hs:718:17: error: [GHC-88464]
    Variable not in scope: unless :: Bool -> Expectation -> f0 ()
    |                               
718 |                 unless        
    |                 ^^^^^^        
[2 of 6] Compiling Data.Mergeful.ItemSpec
[3 of 6] Compiling Data.Mergeful.TimedSpec
[4 of 6] Compiling Data.Mergeful.ValueSpec
[6 of 6] Compiling Paths_genvalidity_mergeful
Progress 96/98    

but don't worry - since it only effects the test suite I will skip the tests for now and will re-enable all your packages (I'm just waiting for a successful nightly build before merging #7143 (introducing more changes))

NorfairKing commented 1 year ago

@alaendle Looks like I forgot to upload the changes. genvalidity-mergeful 0.3.0.1 is now uploaded.