commercialhaskell / stackage

Stable Haskell package sets: vetted consistent packages from Hackage
https://www.stackage.org/
MIT License
529 stars 806 forks source link

HUnit 1.3 #768

Closed snoyberg closed 8 years ago

snoyberg commented 9 years ago

HUnit-1.3.0.0 depended on by:

bergmark commented 9 years ago

test-framework-hunit is probably blocking a lot of packages here.

DanBurton commented 9 years ago

Update: mostly the same.

HUnit-1.3.0.0 depended on by:

glguy commented 9 years ago

test-framework-hunit updated on hackage

jpvillaisaza commented 9 years ago

twitter-feed-0.2.0.3 is updated and in Hackage.

bergmark commented 9 years ago

yay thank you @glguy

bergmark commented 9 years ago

feed, rest-core, rest-gen fixed

bergmark commented 9 years ago

Also fixed fclabels, ping @sebastiaanvisser

byorgey commented 9 years ago

Uploaded diagrams-contrib-1.3.0.5.

DanBurton commented 9 years ago

Update: the to-do list is about 30% shorter.

HUnit-1.3.0.0 depended on by:

basvandijk commented 9 years ago

Fixed in: case-insensitive-1.2.0.5

Gabriella439 commented 9 years ago

Fixed in: pipes-extras-1.0.2

mainland commented 9 years ago

Fixed in: exception-transformers-0.4.0.2

bergmark commented 8 years ago

Woops wrong issue number.

basvandijk commented 8 years ago

Fixed in: concurrent-extra-0.7.0.10

bergmark commented 8 years ago

We decided to start the new year and the upcoming LTS 4 with a clean slate. We'll be disabling most packages that block upgrades. Please send a pull request to re-enable your package if you update it. If you do so before new years you'll be included in LTS 4.

The following packages have been disabled because they have HUnit as a non-test dependency:

The test-suites of these packages have been disabled. These packages will still be included in LTS 4 but if you want stackage to run your test-suite please update affected packages and send us a pull request to re-enable it.

bergmark commented 8 years ago

@myfreeweb The hspec-expectations-pretty-diff repo doesn't have issues enabled so I'll comment here. The test-suite will be disabled since it doesn't build with the latest HUnit, please open a pull request to re-enable it if this is fixed.

Preprocessing test suite 'tests' for hspec-expectations-pretty-diff-0.7.2.2...
[1 of 3] Compiling Test.Hspec.Expectations.PrettySpec ( test/Test/Hspec/Expectations/PrettySpec.hs, dist/build/tests/tests-tmp/Test/Hspec/Expectations/PrettySpec.o )

test/Test/Hspec/Expectations/PrettySpec.hs:14:1:
    Duplicate instance declarations:
      instance Eq HUnitFailure
        -- Defined at test/Test/Hspec/Expectations/PrettySpec.hs:14:1
      instance Eq HUnitFailure -- Defined in ‘Test.HUnit.Lang’
bergmark commented 8 years ago

Also disabled the test-suite for yesod-static-angular @wuzzeb

test/RunGenerator.hs:37:24:
    Ambiguous occurrence ‘Location’
    It could refer to either ‘Test.HUnit.Location’,
                             imported from ‘Test.HUnit’ at test/RunGenerator.hs:8:1-17
                             (and originally defined in ‘Test.HUnit.Lang’)
                          or ‘Yesod.EmbeddedStatic.Types.Location’,
                             imported from ‘Yesod.EmbeddedStatic.Types’ at test/RunGenerator.hs:10:1-33

test/RunGenerator.hs:52:27:
    Ambiguous occurrence ‘Location’
    It could refer to either ‘Test.HUnit.Location’,
                             imported from ‘Test.HUnit’ at test/RunGenerator.hs:8:1-17
                             (and originally defined in ‘Test.HUnit.Lang’)
                          or ‘Yesod.EmbeddedStatic.Types.Location’,
                             imported from ‘Yesod.EmbeddedStatic.Types’ at test/RunGenerator.hs:10:1-33
valpackett commented 8 years ago

@bergmark released hspec-expectations-pretty-diff 0.7.2.3, should work now

bergmark commented 8 years ago

Thanks!

qnikst commented 8 years ago

@bergmark it's a bit unfortunate that you've not mentioned maintainer name when was written about problems with network-transport-zeromq, so I was not aware of this situation at all. I tried to reproduce a problem for me but was not able to do that, as this package doesn't have direct dependency on HUnit, neither indirect dependency with fixed upper bound. How could I reproduce a problem in order to fix it?

bergmark commented 8 years ago

@qnikst I don't remember the details from back then, it seems the package can be re-enabled.

At the moment network-transport-zeromq depends on distributed-process-tests (which has an outdated HUnit dep) via a non-manual flag. We could re-enable network-transport-zeromq if we skip building the test-suites, but the solution I recommend is to change that flag to have manual: True. Then we can ignore just the test suites depending on distributed-process-tests.

You might also want to make the install-benchmarks flag manual.

DanBurton commented 8 years ago

@qnikst @bergmark I've re-enabled network-transport-zeromq, but I also added it to the skipped-tests section. Here's the bounds problem that I get when it's not part of the skipped tests section:

HUnit-1.3.1.1 depended on by:

I haven't looked as closely at the flag situation, but one simple way to solve this problem is to get distributed-process-tests to support HUnit 1.3.

qnikst commented 8 years ago

@DanBurton @bergmark thanks, I'll take a look at distributed-process-tests now.

qnikst commented 8 years ago

Hm.. latest distributed-process-tests supports HUnit 1.3, but there the major release will be needed, so it will take sometime. I'll try to backport HUnit support and see if we can release minor release with this change only. I'll send a PR once everything will be ready.