search

commfish / GCLr

Gene Conservation Lab R package repository
3 stars 0 forks source link

merging to version 0.4.4; bugfixes for QC #64

Closed krshedd closed 1 year ago

krshedd commented 1 year ago

Just 1 minor bugfix to dupcheck_qc_conflicts. The previous version was not properly removing conflict fish that had dropped out due to missing loci (<80%) in the project or QC. This caused an issue for Jodi in S259QC, since all 3 conflict fish were dropped due to missing loci in the QC.

krshedd commented 1 year ago

I should add, I tested my update on S259, S257, and S253. No issues.

krshedd commented 1 year ago

I also added an enhancement to loo_roc_rate_calc to calculate precision TP / (TP + FP) for the output.

Side bar, this is probably what folks mean when they talk about having specific branches for specific bugs/enhancements.

krshedd commented 1 year ago

Hi all, I'm going to force merge this, Jodi ran into the same QC issue with S262.