commit-crimes / shelf-life

1 stars 0 forks source link

Feat/132 add image fetching to foodfacts #133

Closed alextheprophecy closed 1 week ago

alextheprophecy commented 1 week ago

PR: Feat/Add `imageUrl` handling to FoodFacts

Summary

This PR introduces a refactor in the FoodFacts data class and enhances the OpenFoodFactsRepository to also handle the imageUrl property when extracting JSON product details from OpenFoodFacts.

Changes

Refactor (FoodFacts Data Class)
- Introduced a default image URL constant for imageUrl in FoodFacts, it is placed in a companion object
- imageUrl will default to this blank placeholder image
Enhancement (extractFoodFactsFromJson function)
- Updated the extractFoodFactsFromJson function inside OpenFoodFactsRepository function to extract the image Url or else use the default FoodFacts placeholder

Tests

(OpenFoodFactsRepositoryTest) Enhanced existing tests to validate that imageUrl is correctly sent back if it exists, and defaults to the placeholder when invalid

Next steps

The OpenFoodFacts API sends back multiple images of multiple sizes. In the future we should store these multiple images, to adapt our UI to the viewport, and to optimize when we use smaller images (e.g we do not need large images for food icons)

sonarcloud[bot] commented 1 week ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud