Ability to override registry

commitdev / zero

Allow startup developers to ship to production on day 1

https://getzero.dev

Mozilla Public License 2.0

557 stars 51 forks source link

Ability to override registry #470

Closed JeanPinzon closed 2 years ago

JeanPinzon commented 2 years ago

Issue: #469

Add registry.yaml with the default stacks;
Add the parameter registry-file-path to override the file path on the command init. It can be a local or a github path.

JeanPinzon commented 2 years ago

Thanks for your contribution!! I wonder going forward if we still need to use the local-module-path given we can override the entire registry, but we can remove it in a different PR if we find ourselves not using it anymore

I'm not sure if local-module-path is just used on registry, but if so, it would be interesting to remove it and put the entire URL on the registry file. With this approach, it would be possible to have stacks with templates from different GitHub accounts.

JeanPinzon commented 2 years ago

Please let me know if you think it should be implemented on this PR 😄

davidcheung commented 2 years ago

Yeah i think the registry file "should" cover all the use cases, go-getter allows a pretty wide range of paths it is a breaking change though (which only affects development on modules)

@bmonkman what do u think about removing the local-module-path entirely?

bmonkman commented 2 years ago

Let's just leave the local module path for now and remove it separately later if we truly end up not using it. I think it's still probably useful as-is when using default values.