search

commitizen / cz-cli

The commitizen command line utility. #BlackLivesMatter
http://commitizen.github.io/cz-cli/
MIT License
16.83k stars 551 forks source link

Why cz-conventional-changelog is not the default adapter? #762

Closed felipecrs closed 4 years ago

felipecrs commented 4 years ago

I believe it's the most used since it's the one that best complies with conventionalcommits.org.

jimthedev commented 4 years ago

I would be ok with it being the default. The reason for it not being the default is that this was created before conventionalcommits.org existed so we didn't really know what convention would "win". I would be ok with a major version that makes it the default when initializing. I think it would be a good change so long as we still allow for people to define alternative adapters.

felipecrs commented 4 years ago

@dmwelch should I open a new issue for proposing this change?

dmwelch commented 4 years ago

Sorry, I was thinking this would go into the development backlog for the next major release. I'll reopen it and tag it as such.

felipecrs commented 4 years ago

Okay, I just found that cz-conventional-changelog is already the default adapter. The problem with:

If your repo is NOT Commitizen friendly:

If you're not working in a Commitizen friendly repository, then git cz will work just the same as git commit but npx cz will use the streamich/git-cz adapter. To fix this, you need to first make your repo Commitizen-friendly

Is that:

  1. npx cz was used to be npx git-cz, and git-cz on NPM points to streamich's.
  2. $ npx cz
command not found: cz
  3. Instead of falling back to the normal git commit, we should proceed using the default adapter.
commitizen-bot commented 4 years ago

:tada: This issue has been resolved in version 4.2.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: