Ownership of find-node-modules

commitizen / cz-cli

The commitizen command line utility. #BlackLivesMatter

http://commitizen.github.io/cz-cli/

MIT License

16.89k stars 552 forks source link

Ownership of find-node-modules #863

Open callumacrae opened 3 years ago

callumacrae commented 3 years ago

Hey!

I'm the maintainer of find-node-modules, and commitizen is… pretty much the only project using it as a dependency! I haven't used it myself in years and every time people open an issue about a vulnerable dependency, they're using it via this project.

Would commitizen be interested / up for taking ownership of the package? I feel like I've been neglecting it a bit.

I'd be happy to either transfer it to the commitizen org or add some maintainers, whatever works for you :)

LinusU commented 3 years ago

Looking at our code, we are actually just grabbing the first match:

https://github.com/commitizen/cz-cli/blob/12442c160046e4e09c94379675840663456b0fa7/src/commitizen/adapter.js#L94-L110

So the best for cz-cli would be to just call findup-sync directly (or potentially find-up which seems to be more popular).