search

commitizen / cz-cli

The commitizen command line utility. #BlackLivesMatter
http://commitizen.github.io/cz-cli/
MIT License
16.78k stars 551 forks source link

Recreate the commitizen logo in png & svg format #878

Closed bromso closed 2 years ago

LinusU commented 2 years ago

Awesome!

What is the use case for adding so many different sizes of the same image? Binary files are not great to put in Git because every version of the file gets stored forever and needs to be downloaded every time you git clone. How about keeping just the SVG files in the repository?

dmwelch commented 2 years ago

@LinusU Already on it - should have a commit addressing that shortly...

dmwelch commented 2 years ago

@bromso I narrowed down the generated sizes according to some very hasty online research. I added 16x16 for the VSCode icon use case, then: 48, 96, 256, 512, 1024. Adding more sizes is trivial, (see line 24 in generate.sh) but I'd rather have more information on use cases.

@LinusU I wanted to set up the Azure pipeline to generate them as build artifacts but not sure if I did that correctly (still learning this tech stack). I avoided using svgexport and went with Python's cairosvg because I don't think the containers on Azure have browsers and testing on Docker locally demonstrated that svgexport requires the browser to render the PNG files.

bromso commented 2 years ago

@dmwelch It all sounds good to me. As long as you guys are happy, I'm happy! 😄

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 4.2.5 :tada:

The release is available on:

Your semantic-release bot :package::rocket: