commitizen / cz-cli

The commitizen command line utility. #BlackLivesMatter
http://commitizen.github.io/cz-cli/
MIT License
16.89k stars 552 forks source link

fix: process does not terminate after creating a commit with the --re… #974

Closed coffe0wl closed 1 month ago

coffe0wl commented 1 year ago

Problem:

The problem appears when the user creates a commit with the --retry option.

When creating a commit without this parameter, the process will be completed by a function that acts as a prompt, since without this parameter this function is not executed because the data is taken from the cache, the process was not completed.

Therefore, a line was added that terminates the process in case there was no error.

markovdigital commented 9 months ago

Hi, @jimthedev

Is there any chance this fix will land? The --retry workflow doesn't seem to work without it.

simplenotezy commented 3 months ago

I am also experiencing --retry not working; is that because of this missing PR?

It just hangs forever:

image
yrambler2001 commented 1 month ago

@simplenotezy

is that because of this missing PR

yes

It just hangs forever

it hangs, you can press ctrl-c to stop the execution, and the commit will be committed.

jimthedev commented 1 month ago

The CI job for this is long gone so I can't re-run. I am creating an alternative branch and will give it a try.

jimthedev commented 1 month ago

Mirror PR: https://github.com/commitizen/cz-cli/pull/1001

github-actions[bot] commented 1 month ago

:tada: This issue has been resolved in version 4.3.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

jimthedev commented 1 month ago

Let me know if there are other PRs you want prioritized. I can't promise I will get to them all, but we can try :D Also if you can let me know if this worked, I'd appreciate it.