search

commitizen / cz-conventional-changelog

A commitizen adapter for the angular preset of https://github.com/conventional-changelog/conventional-changelog
MIT License
768 stars 442 forks source link

Add support for optional exclamation mark (!) #155

Open EndzeitBegins opened 3 years ago

EndzeitBegins commented 3 years ago

According to conventional commits, a breaking change can also be denoted by adding an exclamation mark (!) after type / scope. This improves the visibility of breaking changes by making them visible in the commit message header.

fix(api)!: omit keys of undefined elements in JSON responses

BREAKING CHANGE: < reason here >

We started to take a look at Commitizen in combination with @digitalroute/cz-conventional-changelog-for-jira. Instead of contributing the feature there, I thought it would be more effective to contribute this feature "upstream" instead, as it has nothing to do with Jira.

Any thoughts about this? Are PRs welcome? Thanks in advance for the great work so far!

cgaube commented 2 years ago

One alternative you can do until this is managed via commitzen is to use the -e option when committing 

git cz -a -e

it will trigger the helper where you can select the types etc then when everything is done will open the commit message and allow you to edit it (via vim or other editor)- from there you can manually add the ! yourself

annoying for sure

Any thoughts about this? Are PRs welcome?

I would assume that any PR are welcome..