common-fate / granted

The easiest way to access your cloud.
https://granted.dev
MIT License
1.04k stars 93 forks source link

use brew --prefix instead of hardcoded path for fish alias #437

Closed admackin closed 1 year ago

admackin commented 1 year ago

the hardcoded path doesn't work on brew installs on apple silicon (or if someone specifies an alternate location for brew)

What changed?

Used brew --prefix to get root homebrew location

Why?

as reported in #246 the alias installation doesn't work for fish on Apple Silicon (M1/M2) since the homebrew binaries are installed in /opt/homebrew rather than /usr/local

How did you test it?

Manually inserted the same change in my local config.fish (on Apple silicon).

Potential risks

not e2e-tested on intel macs (but I have verified that brew --prefix command works identically on intel-based Brew, which I also have installed)

Is patch release candidate?

yes, it's a small bugfix that should make things work for all people who use Fish on Apple Silicon, and be unnoticed by everyone else.