common-fate / granted

The easiest way to access your cloud.
https://granted.dev
MIT License
1.01k stars 93 forks source link

Assume can't find firefox and doesn't work with path supplied #476

Closed ColinCee closed 11 months ago

ColinCee commented 11 months ago
> assume -c
[i] Thanks for using Granted!
[i] By default, Granted will open the AWS console with this browser: Firefox
[!] Granted works best with Firefox but also supports Chrome, Brave, and Edge (https://docs.commonfate.io/granted/introduction#supported-browsers). You can change this setting later by running 'granted browser set'
? Use Firefox as default Granted browser? Yes
[!] Granted could not detect an existing installation of Firefox at known installation paths for your system
[i] If you have already installed this browser, you can specify the path to the executable manually
? Please enter the full path to your browser installation for Firefox: /Applications/Firefox\ Developer\ Edition.app/Contents/MacOS/firefox
[✘] The path you entered is not valid

Not really sure why this is invalid as it opens firefox when I enter /Applications/Firefox\ Developer\ Edition.app/Contents/MacOS/firefox in the terminal

shwethaumashanker commented 11 months ago

Hey @ColinCee, Thank you for using granted and bringing up this issue. Can you please let me know:

So I can try and replicate the error.

shwethaumashanker commented 11 months ago

Hey @ColinCee, I managed to replicate the error and found a fix by removing the backslashes in the path while keeping the spaces intact: /Applications/Firefox Developer Edition.app/Contents/MacOS/firefox. It seems our filtering might not handle backslashes well, so I'll go ahead and create a ticket to get that sorted. Let me know if this works for you! 😊

Make sure to download our Firefox extension for better UX: https://docs.commonfate.io/granted-cli/browsers/