search

common-fate / granted

The easiest way to access your cloud.
https://granted.dev
MIT License
964 stars 91 forks source link

Brave browser crashes after granted upgrade #498

Closed houstonj1 closed 8 months ago

houstonj1 commented 9 months ago

I don't know which version this was introduced in, but previously I was able to create a new browser session using Brave with the following command 

assume -c

I noticed on version 0.16.1 that the same command now crashes all open instances of Brave. If anyone has any thoughts or solutions, much appreciated!

This is still the case after upgrading to the latest version 0.17.1, installed on an M1 Mac using Homebrew

Thanks in advance!

Sunac commented 9 months ago

I've noticed the same on Chrome after update to 0.17.1 on M1 Mac.

houstonj1 commented 9 months ago

After upgrading to 0.19.0, this is still an issue. Thanks for connecting this issue to #515 @Eddie023 ! 💯

Eddie023 commented 9 months ago

@houstonj1 Thanks for confirmation. Quick question: does your profile contain slashes? We have identified that profiles with slashes were failing for some users. and we have recently pushed a fix for that https://github.com/common-fate/granted/pull/525 should be out in next release. Let me know if that fixes your issue!

houstonj1 commented 9 months ago

@Eddie023 Thanks for getting back to me :) When I run assume -c, the aws profiles look like this 

account-alias/role-name
account-alias-2/role-name

So yes, I think that is what you are looking for when you ask if there are slashes. Again, thanks for working on this and pushing out new releases ❤️

houstonj1 commented 8 months ago

This is now working in v0.19.2 🎉 Thanks for the work here @Eddie023