Added options to configure Waterfox as a browser and prompt for install of the Firefox extension into Waterfox.
Why?
I had set up Waterfox originally by just providing the path to Waterfox instead of Firefox, but if a user had Firefox already installed to its default path, this might not have worked.
How did you test it?
Tested on MacOS
built the CLI locally with PREFIX=~/.local make cli
ran dgranted browser set
selected Waterfox
ran dassume -c <profile_name>
Waterfox opens to AWS console with correct login, container name, and container icon from ~/.aws/config
_I have not tested this on linux or windows so I took my best guess on the path for windows based on this reddit post. If the path is incorrect the user can correct it as usual and/or file an issue to have the default updated._
Potential risks
Leveraging some shared code with Firefox to launch / control Waterfox. If Waterfox diverges there could be issues here, however that seems unlikely since diverging may cause a lot of issues for Waterfox users in general.
What changed?
Added options to configure Waterfox as a browser and prompt for install of the Firefox extension into Waterfox.
Why?
I had set up Waterfox originally by just providing the path to Waterfox instead of Firefox, but if a user had Firefox already installed to its default path, this might not have worked.
How did you test it?
Tested on MacOS
PREFIX=~/.local make clidgranted browser setWaterfoxdassume -c <profile_name>~/.aws/configPotential risks
Leveraging some shared code with Firefox to launch / control Waterfox. If Waterfox diverges there could be issues here, however that seems unlikely since diverging may cause a lot of issues for Waterfox users in general.
Is patch release candidate?
Link to relevant docs PRs