fix chrome profiles not launching if they contain slashes + automatically rename Chrome profiles - Githubissues

common-fate / granted

The easiest way to access your cloud.

https://granted.dev

MIT License

1.06k stars 93 forks source link

fix chrome profiles not launching if they contain slashes + automatically rename Chrome profiles #525

Closed chrnorm closed 11 months ago

chrnorm commented 11 months ago

What changed?

AWS profiles containing slashes like my/profile now correctly open in Chrome and Chromium-based browsers
Automatically renames Chrome profiles from 'Person 2', 'Person 3', etc to the name of the AWS profile

(note: the automatic renaming happens the second time that Chrome is launched - on the initial launch you'll still see 'Person 2')

Also removes UserDataPath from the ChromeLauncher struct as it is unused.

Why?

Fixes #524

How did you test it?

Tested locally with Chrome on MacOS to verify that profiles with slashes now open, and profiles are automatically renamed

Potential risks

People with existing Chrome profiles held over from an earlier version of Chrome may have profiles recreated. I think this is unlikely to occur, and if it does, you can edit the Chrome Local State file to adjust the IDs of your profiles.

Is patch release candidate?

No - automatic renaming of Chrome profiles should be a minor change

Link to relevant docs PRs