search

common-fate / granted

The easiest way to access your cloud.
https://granted.dev
MIT License
1.06k stars 94 forks source link

support exec using shell script for TTY applications #549

Closed JoshuaWilkes closed 10 months ago

JoshuaWilkes commented 11 months ago

What changed?

Fixes #250

Uses the shell script to exec commands instead of Go, this enables TTY applications to work as expected

@TODO need to implement the exec feature in the other shell scripts

https://www.loom.com/share/dead201f196a44da8df631c562ff83ef

Why?

Some programs like Bash would not work otherise

How did you test it?

Potential risks

Exec is now dependent on the shell script, so assumego cannot be called directly to exec. Though I don't think this would be an issue for anyone

Coudl mitigate this by still supporting Go based exec as well as shell based exec

Is patch release candidate?

Link to relevant docs PRs

lgg42 commented 10 months ago

I'm so looking forward to this merge! In my case it is for using terragrunt apply wrapped by assume, e.g.

assume testing/RoleFoo --exec -- terraform apply

right now it is failing with

│ Error: error asking for approval: EOF