common-fate / granted

The easiest way to access your cloud.
https://granted.dev
MIT License
956 stars 90 forks source link

add a check for empty access key ID when caching #632

Closed chrnorm closed 2 months ago

chrnorm commented 2 months ago

What changed?

adds a check to prevent caching credentials if the access key is empty

Why?

prevents an issue where if the granted credential-process returned an empty JSON, Granted would cache it and require manually clearing the cache.

How did you test it?

testing the granted credential-process integration. To reproduce, add a credential process which returns a JSON with an empty access key ID. The previous behaviour is that Granted will cache this, which causes the AWS CLI to stop working.

Potential risks

Low risk as the access key should never be empty.

Is patch release candidate?

Yes

Link to relevant docs PRs