common-fate / granted

The easiest way to access your cloud.
https://granted.dev
MIT License
956 stars 90 forks source link

Ensure "firefoxstdout" doesn't get prefix-matched as "firefox" #635

Closed gautamg795 closed 2 months ago

gautamg795 commented 2 months ago

What changed?

The GetBrowserKey function has been fixed to return the correct FirefoxStdoutKey.

Why?

Previously, this value would never be returned as the function performs a Contains match, and firefoxstdout does contain the string "firefox" which would return the wrong key.

How did you test it?

Honestly, just visual inspection after finding that providing FirefoxStdout to granted browser set was still prompting for a path.

Potential risks

None