common-fate / granted

The easiest way to access your cloud.
https://granted.dev
MIT License
955 stars 90 forks source link

Increase backoff for attempted assume #640

Closed meyerjrr closed 2 months ago

meyerjrr commented 2 months ago

What changed?

Implemented a fibonacci backoff retry when requesting access via Common Fate and waiting for the access to be live.

Why?

The current backoff retry was too short and caused some users to get bad UX when requesting access with Common Fate and subsequentially assuming the role. The access would not be provisioned yet and would receive the error

[✘] no access: operation error SSO: GetRoleCredentials, https response error StatusCode: 403, RequestID: 123456-db64-42f3-88a8-asdfjk3434, api error ForbiddenException: No access

How did you test it?

Assuming a role with the live assume command with the current functionality and replicating the error above. The assuming the same role via the dev assume command dassume and monitored the result. The wait was longer and no error was returned

Potential risks

For users that are not using Common Fate and try assuming a role they do not have access to will have to wait for the retry

Is patch release candidate?

Link to relevant docs PRs