common-good / cgmembers-frame

Other
3 stars 2 forks source link

Container orchestration for development + test #22

Open skinnyjames opened 11 months ago

skinnyjames commented 11 months ago

Hello,

I'm peeking around at how the Common Good payment system works from a technical perspective, and find the setup instructions from the link in the README.md helpful, but perhaps missing some information. I also see setup instructions for using virtualization.

Has containerization (Docker, etc) been considered for developing locally or running tests in CI? One benefit to using containerization is a portable way to spin up the application dependencies without having to install them locally or setting up a VM manually. Another benefit is prepping an application to be testable in CI.

I implemented container orchestration on my local to get a better sense of what is required to run this application locally, and have had some good luck with simplifying the setup. If this is something wanted or relevant, I'm happy to iterate on a PR.

samcooley commented 11 months ago

Hi,

I think it is a great idea, and there was already some work done on this, so you might be interested in these branches: https://github.com/common-good/cgmembers-frame/tree/feature/docker-dev-env https://github.com/common-good/cgmembers-frame/tree/feature/vagrant

Thanks for whatever you are able to contribute.

WilliamSpademan commented 11 months ago

Thanks Sean (skinnyjames)! and thanks Sam!

I totally agree with Sam. Great idea and thanks for whatever you contribute.

😀 William

— William Spademan (he) Executive Director

Common Good ® Tools for a new economy™

See our video http://cg4.us/video. https://www.facebook.com/commongoodearth/ https://www.instagram.com/commongoodearth/

CommonGood.earth +1 413 628 1723 office +1 413 628 1957 direct line PO Box 21, Ashfield, MA 01330 USA

On Wed, Dec 6, 2023 at 8:52 AM Sam Cooley @.***> wrote:

Hi,

I think it is a great idea, and there was already some work done on this, so you might be interested in these branches: https://github.com/common-good/cgmembers-frame/tree/feature/docker-dev-env https://github.com/common-good/cgmembers-frame/tree/feature/vagrant

Thanks for whatever you are able to contribute.

— Reply to this email directly, view it on GitHub https://github.com/common-good/cgmembers-frame/issues/22#issuecomment-1842931056, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKZTDA6BMQ7MZR4YWOXJRTYIB2CPAVCNFSM6AAAAABAJKNX52VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBSHEZTCMBVGY . You are receiving this because you are subscribed to this thread.Message ID: @.***>

skinnyjames commented 11 months ago

Thanks all!

The links are definitely helpful in giving me a sense of the setup. I did stand up a PR this morning at #23, and used Apache instead of Nginx - I'm not sure which is preferred or currently used.

I might need a bit of guidance around the need for any extra data setup (regions, tax information) if it isn't expected to work out of the box. Otherwise, I'll keep iterating on it as I find time to get the tests passing, and I'm happy to open issues for anything new I encounter in the process.

WilliamSpademan commented 11 months ago

Thanks Sean!

Fantastic.

We are totally shifting over to Nginx.

Let us know if/when you get stuck.

Yours, William

— William Spademan (he) Executive Director

Common Good ® Tools for a new economy™

See our video http://cg4.us/video. https://www.facebook.com/commongoodearth/ https://www.instagram.com/commongoodearth/

CommonGood.earth +1 413 628 1723 office +1 413 628 1957 direct line PO Box 21, Ashfield, MA 01330 USA

On Thu, Dec 7, 2023 at 6:53 PM skinnyjames @.***> wrote:

Thanks all!

The links are definitely helpful in giving me a sense of the setup. I did stand up a PR this morning at #23 https://github.com/common-good/cgmembers-frame/pull/23, and used off Apache instead of Nginx - I'm not sure which is preferred or currently used.

I might need a bit of guidance around the need for any extra data setup (regions, tax information) if it isn't expected to work out of the box. Otherwise, I'll keep iterating on it as I find time to get the tests passing, and I'm happy to open issues for anything new I encounter in the process.

— Reply to this email directly, view it on GitHub https://github.com/common-good/cgmembers-frame/issues/22#issuecomment-1846281499, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKZTDDTRDHSQ2ILI7IPY53YIJJIFAVCNFSM6AAAAABAJKNX52VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBWGI4DCNBZHE . You are receiving this because you commented.Message ID: @.***>