common-voice / cv-sentence-extractor

Scraping Wikipedia for fair use sentences
52 stars 52 forks source link

Fix command position of arguments and make title-filter-list optional #201

Closed MichaelKohler closed 1 year ago

MichaelKohler commented 1 year ago

With the recent rewrite of the clap part of the CLI, the position of the arguments changed. With this version the arguments that are valid for all commands need to be before the actual command name. The other option would be to specify that they are indeed global, but then they for some reason can't be required. So this adjusts the pipeline scripts to the correct format.

Additionally this PR also makes --title-filter-list optional for the extract command.